bump clap dependency to 4.x #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks very promising. I will have a closer look next week. |
This gets rid of two security advisories [1, 2] reported by `cargo audit` [3]. After this commit, no other vulnerabilities are reported by the tool. This is a heavily breaking change, as the `Callback` trait had to be adapted. We prefer to keep the diff as minimal as possible, rather than strive for the maximally idiomatic code. Thus, we refrain for now from optimizations such as deriving `clap::ValueEnum` on `blockchain::parser::types::CoinType`, or using `clap::command!()` to read the crate author and version from the Cargo manifest. We reshuffle the argument parsing code a bit in order to be able to add a set of unit tests that assert some basic desired behaviors. The updated help text is reflected in the diff of the README file. [1] https://rustsec.org/advisories/RUSTSEC-2021-0139 [2] https://rustsec.org/advisories/RUSTSEC-2021-0145 [3] https://crates.io/crates/cargo-audit
|
LGTM, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of two security advisories [1, 2]
reported by
cargo audit[3]. After this commit,no other vulnerabilities are reported by the tool.
This is a heavily breaking change, as the
Callbacktrait had to be adapted.We prefer to keep the diff as minimal as possible, rather than strive for the maximally idiomatic code. Thus, we refrain for now from optimizations such as deriving
clap::ValueEnumonblockchain::parser::types::CoinType, or usingclap::command!()to read the crate author andversion from the Cargo manifest.
We reshuffle the argument parsing code a bit in
order to be able to add a set of unit tests that
assert some basic desired behaviors.
The updated help text is reflected in the diff of
the README file.
[1] https://rustsec.org/advisories/RUSTSEC-2021-0139
[2] https://rustsec.org/advisories/RUSTSEC-2021-0145
[3] https://crates.io/crates/cargo-audit
Closes #95.