-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'To Base91' and 'From Base91' Operations #1081
base: master
Are you sure you want to change the base?
Conversation
I wanted this feature too, please consider this feature! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be quite a few bases
I’d like to throw my hat in for base94. I submitted a pull request several months back and would appreciate it having a second look. Or first look as the case may be.
Best,
Sebastian
________________________________
From: Alexander Craggs ***@***.***>
Sent: Monday, June 28, 2021 10:24:48 AM
To: gchq/CyberChef ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [gchq/CyberChef] Add 'To Base91' and 'From Base91' Operations (#1081)
@popey456963 commented on this pull request.
After this PR we would have Base 32, 58, 62, 64, 85 and 91. I wonder if we could combine all of these operations into a 'From Base N' or 'To Base N' operator. The default alphabet for each base could be selected from a dropdown.
________________________________
In src/core/operations/FromBase91.mjs<#1081 (comment)>:
+import Operation from "../Operation.mjs";
+import { ALPHABET_OPTIONS, fromBase91 } from "../lib/Base91.mjs";
+/**
+ * From Base91 operation
+ */
+class FromBase91 extends Operation {
+
+ /**
+ * FromBase91 constructor
+ */
+ constructor() {
+ super();
+
+ this.name = "From Base91";
+ this.module = "Default";
+ this.description = "BasE91 is an encoding method that uses ASCII characters. Similar to base64, it has the advantage of limiting the size of the encoded data and to be used as a cipher.";
Capitalised 'E' on 'BasE91'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#1081 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKWFL3P55M3PCG367AOXK33TVCA3BANCNFSM4PWHWYWA>.
|
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
Add 'To Base91' and 'From Base91' Operations