Added 'LZString Decompress' and 'LZString Compress' operations #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! It is likely the issues you were seeing were to do with the node versions you are using, as CyberChef only supports Node v10, as stated in the README. |
crespyl
force-pushed
the
add-lz-string
branch
from
c8fc17c to
671ae65
Compare
|
Thanks for the feedback! That makes perfect sense; fortunately I was able to use the Dockerfile from #1215 to get an appropriate version of Node up and running to run the tests against, and I've updated the PR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688
I've also made some tweaks that were necessary to get the app and tests running on my machine (adding
--experimental-json-modulesto some node invocations, and.mjsextensions in some import statements). I'm not entirely clear whether the issues I had are just due to my versions of npm/node (7.3.0 and v15.5.1 respectively), so if necessary I can update this PR to limit it to just the new operations and tests.