prefer const 1 of 5 #127
Closed
prefer const 1 of 5 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this starts enabling the prefer-const option. First it auto-fixes as many prefer-const errors as possible, then I manually went through and fixed ~100 errors manually. To avoid doing all 500 or so in one go and then having to rebase all changes as other PRs get merges, I'll do a chunk whenever I get bored, and PR it when I get even more bored. |
graingert
commented
May 3, 2017
| @@ -38,9 +43,6 @@ SeasonalWaiter.prototype.load = function() { | |||
| * #spiderchef | |||
| */ | |||
| SeasonalWaiter.prototype.insertSpiderIcons = function() { | |||
| let spider16 = "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAB3UlEQVQ4y2NgGJaAmYGBgVnf0oKJgYGBobWtXamqqoYTn2I4CI+LTzM2NTulpKbu+vPHz2dV5RWlluZmi3j5+KqFJSSEzpw8uQPdAEYYIzo5Kfjrl28rWFlZzjAzMYuEBQao3Lh+g+HGvbsMzExMDN++fWf4/PXLBzY2tqYNK1f2+4eHM2xcuRLigsT09Igf3384MTExbf767etBI319jU8fPsi+//jx/72HDxh5uLkZ7ty7y/Dz1687Avz8n2UUFR3Z2NjOySoqfmdhYGBg+PbtuwI7O8e5H79+8X379t357PnzYo+ePP7y6cuXc9++f69nYGRsvf/w4XdtLS2R799/bBUWFHr57sP7Jbs3b/ZkzswvUP3165fZ7z9//r988WIVAyPDr8tXr576+u3bpb9//7YwMjKeV1dV41NWVGoVEhDgPH761DJREeHaz1+/lqlpafUx6+jrRfz4+fPy+w8fTu/fsf3uw7t3L39+//4cv7DwGQYGhpdPbt9m4BcRFlNWVJC4fuvWASszs4C379792Ldt2xZBUdEdDP5hYSqQGIjDGa965uYKCalpZQwMDAxhMTG9DAwMDLaurhIkJY7A8IgGBgYGBgd3Dz2yUpeFo6O4rasrA9T24ZRxAAMTwMpgEJwLAAAAAElFTkSuQmCC", | |||
There was a problem hiding this comment.
@n1474335 what crazy nonsense is this? What's wrong with import './path/to/image'?
|
closing in favour of #126 |
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
[FIX] Missing translation on Login screen Fixes gchq#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.