-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JPath expression operation #171
Conversation
I've now added tests and changed the library over - unfortunately, I can't use the npm package for jsonpath as it causes errors in webpack, which have been reported by other users. Instead I'm using a pre-packed file of the library which is the recommended fix by the author for this issue. Other users have found success by requiring it as a webpack external package but that wouldn't work for CyberChef's use case. |
Nice work. I've made a couple of slight changes, improving error messages with a bit more detail. I found a fairly simple workaround for importing the jsonpath library which I've implemented. It's better to import our dependencies through npm if at all possible as it allows us to manage their updates in a more automated fashion. Thanks for checking another operation off the list! |
@n1474335 That is really weird - I was using that fix, but when building for tests, it wouldn't work at all! I wonder why it worked out for you... |
Not sure. I've recently updated some of the dependencies, including webpack itself, so that might be the difference. |
[FEATURE] Granular User Access Fixes gchq#165
Should be able to close #96 with this.
Still todo: