bugfix for UTF16 vs UTF8 problems #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
will resubmit with passing lint tests |
|
You don't have to resubmit :) You can just commit to your branch again and
the PR will update.
…On Mon, 14 Jan 2019, 15:20 CrazyDave, ***@***.***> wrote:
will resubmit with passing lint tests
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#471 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACAWfkbNArcbkf37VkGtgprWwcbgaX8cks5vDKAigaJpZM4Z-cWX>
.
|
|
@d98762625 Could this be incorporated into the eventual solution in #291? |
Unfortunately, no (or at least for the current implementation of #291), because it's the "echo" part of the grunt "exec:generateConfig" command, that is causing things to fail. As on Windows, it can output UTF16 instead of UTF8. Closing this temporarily until I can figure out why the Travis CI build is failing with these changes. |
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
[SECURITY] Dependency Updates
This was referenced Sep 26, 2022
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems running UTF16 prompt (i.e. CMD and/or PowerShell on Windows), ECHO will output in UTF16 which will not work in nodeJS (must have UTF8)
This change just moves the actions that were in a grunt file shell command, to a javascript file.