-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Advanced Entropy #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/advanced-entropy
…re/advanced-entropy
This is brilliant. I think this should be added to the current 'Entropy' operation though, rather than being a separate op. |
Great stuff, thanks very much. I made a few improvements to the efficiency so this can now process large files significantly faster. The visualisations are really nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #453
Adds entropy visualizations:
I moved this to a separate operation but this could easily be added to the existing "Entropy" operation.
Each of these visualizations could also be their own operation with associated arguments for customization.
For large files when the operation returns an svg, the input/output threshold would need to be increased by the user otherwise the Dish
_translate
function attempts to escape html content when converting data to an intermediate buffer leaving the output file 0 bytes.I'm open to adding other visualizations or re-working current ones if need be.
Samples
Image
Curve
Histogram (Line)
Histogram (Bar)