Update forge version to 0.9.1 to correct DES and 3DES CTR mode results, and update tests #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #647
This PR updates forge version to 0.9.1 to correct DES and 3DES CTR modes' outputs. forge 0.9.1 also enforces IV size to be the same as the cipher's block size. This PR updates the tests in which IVs are absent or are not the correct size.
The ground truths of tests for DES-CTR and DES-EDE3-CTR modes appear to have been generated by previous versions of forge, and are therefore incorrect. This PR corrects them using the results from GoLang's standard library and pyCryptoDome