Downgrade css-loader dependency for Node 0.10.x compatibility #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the build task under Node 0.10.x fails with the following error: > ERROR in ./~/css-loader!./~/sass-loader!./src/components/widget/style.scss > Module build failed: ReferenceError: Promise is not defined See webpack-contrib/css-loader#144 for details. Node 0.10.x is the latest version available in the Ubuntu package repository, so it's still widely used in dev environments, and should be supported.
gcorne
added a commit
that referenced
this pull request
Dec 29, 2015
|
Thanks for pointing this out. I decided to add an ES6 polyfill instead of downgrading in 62c122f. |
|
Ah, that's a better idea. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the build task under Node 0.10.x fails with the following error:
See webpack-contrib/css-loader#144 for details.
I think Node 0.10.x should be supported, because it's the latest version available in the Ubuntu package repository, so it's still widely used in dev environments.
Alternatively, though, the docs could just state that the project requires a current version of Node.