Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires sdl2 rather than sdl for pkgconfig file #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fundawang
Copy link

In SDL/CMakeLists.txt, sdl2 was detected but sdl was written in output .pc file. It should be sdl2 instead.

@fundawang
Copy link
Author

Or, it should be sdl 1.x rather than sdl 2.x when detecting?

@gdraheim
Copy link
Owner

The sdl-example is based on SDL2, so that's a better thing to do.

The interesting point here is that the same problem exists in the Makefile.am code. I am not sure if something has changed when SDL3 was released in 2022, or that the problem went undetected for about ten years since SDL2 was released in 2013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants