Add support for Groovy DSL #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin DSL was not compatible with Groovy because (1) nested lambdas were executed in the wrong receiver scope and because (2) Groovy functions do not support vararg and trailing closure at the same time. To resolve the first issue uses of the `Action<>` interface were replaced with closures with receiver instead. Also, an overload for each public function that accepts a closure as an argument was added, where instead of the lambda the Groovy `Closure<>` type is used. The second issue is fixed by adding an overload that accepts a list instead of a vararg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin DSL was not compatible with Groovy because (1) nested
lambdas were executed in the wrong receiver scope and because
(2) Groovy functions do not support vararg and trailing closure
at the same time.
To resolve the first issue uses of the
Action<>interface were replacedwith closures with receiver instead. Also, an overload for each public
function that accepts a closure as an argument was added, where instead
of the lambda the Groovy
Closure<>type is used.The second issue is fixed by adding an overload that accepts a list instead
of a vararg.