CI: Download, compile and use latest cppcheck version #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eht16
force-pushed
the
ci_use_recent_cppcheck
branch
from
f897ccf to
6535163
Compare
|
Have you ever considered adding a CodeQL check here or on Geany itself? |
Not relevant to this PR, if "somebody" ran it on the source and posted the results in a separate issue it might be interesting, but please do not pollute PRs with other topics. |
eht16
force-pushed
the
ci_use_recent_cppcheck
branch
from
6535163 to
1562ca0
Compare
|
If there are no objections or improvement suggestions, I would like to merge to this in a week. |
|
If it's working -- why not. I have absolutely no experience with this part of the universe and therefor no objective opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a dated version of "cppcheck" from the runner image, we download the latest release of "cppcheck" and build it.
As building it takes a few minutes, the build result is cached to be re-used in succeeding build runs.
This should make us aware of failed checks in recent "cppcheck" versions quicker. Currently we notice these mostly only when running "make check" locally or when the nightly builds for Debian Unstable fail because they also use recent "cppcheck" versions.
Currently the build fails because of the pending changes in #1309, once this is merged, the build should succeed.