Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geanypy: Drop use of the most obvious deprecated Geany API #363

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

b4n
Copy link
Member

@b4n b4n commented Feb 21, 2016

Also introduce the Document.reload_force() alias to Document.reload_file(), as per non-deprecated Geany API.

@codebrainz @elextr

Also introduce the Document.reload_force() alias to
Document.reload_file(), as per non-deprecated Geany API.
@frlan frlan added this to the 1.28 milestone Mar 13, 2016
@techee techee merged commit 04dcadc into geany:master Jun 9, 2016
@techee
Copy link
Member

techee commented Jun 9, 2016

LGBI.

@elextr I, too, don't know what I'm doing so if there's some other place where the depreciation should be mentioned, please fix it - it's your plugin after all :-P.

@elextr
Copy link
Member

elextr commented Jun 9, 2016

Better push it to upstream codebrainz/geanypy

@elextr
Copy link
Member

elextr commented Jun 9, 2016

@techee its not my plugin, random people who commit stuff to it have just taken over its maintainership.

@elextr
Copy link
Member

elextr commented Jun 9, 2016

See #435

This commit was not approved by the maintainer.

@techee
Copy link
Member

techee commented Jun 9, 2016

@techee its not my plugin, random people who commit stuff to it have just taken over its maintainership.

@elextr OK.

This commit was not approved by the maintainer.

I've previously asked Colomban and Frank if I can merge the Colomban's deprecation-removal patches since they have been lying here for months and the plugin maintainers haven't merged them yet (and most probably won't if they didn't until now), see

#369

@elextr
Copy link
Member

elextr commented Jun 9, 2016

On 9 June 2016 at 23:50, Jiří Techet [email protected] wrote:

@techee https://github.com/techee its not my plugin, random people who
commit stuff to it have just taken over its maintainership.

@elextr https://github.com/elextr OK.

This commit was not approved by the maintainer.

I've previously asked Colomban and Frank if I can merge the Colomban's
deprecation-removal patches since they have been lying here for months and
the plugin maintainers haven't merged them yet (and most probably won't if
they didn't until now), see

​You didn't even ping before doing it.

​I had asked that the deprecation message be put into the ​docstring, which
had not occurred.

As I said in my maintainer resignation, Geany-plugins has become untenable
for maintainers.

#369 #369


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#363 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAxgTUgkje2wfsuquHdRCdK2aagzjMa6ks5qKBo0gaJpZM4HeyOv
.

@b4n
Copy link
Member Author

b4n commented Jun 9, 2016

​I had asked that the deprecation message be put into the ​docstring, which had not occurred.

Okay, I didn't get it was a request for this to be acceptable. I'd be happy to add it, I'd just need to know how it should be done. Is there a way to do that further than writing some random sentence?

@elextr
Copy link
Member

elextr commented Jun 10, 2016

@b4n, AFAIK just use text, probably adding something like "[Deprecated, use ...]" would do.

@techee
Copy link
Member

techee commented Jun 10, 2016

You didn't even ping before doing it.

Sorry. My impression was the maintainers have been pinged enough when the pull request was made and didn't respond for 3 months which I interpreted as either "looks OK" or "don't care about Geany any more".

​I had asked that the deprecation message be put into the ​docstring, which
had not occurred.

Sorry, I didn't interpret your message as not approving the patch.

Since I know nothing about the plugin I didn't explore where such a docstring belongs. And adding it is quite trivial for someone who does - which I assumed was you. Also my impression was that merging this doesn't break anything and that the docstring patch could be added later quite independently.

As I said in my maintainer resignation, Geany-plugins has become untenable
for maintainers.

Again sorry if merging this and other similar patches looked unfriendly - I definitely didn't want to do something against plugin maintainer's will and didn't expect this reaction. Since many plugins are unmaintained and even when they are officially maintained the maintainers don't respond, I think it's necessary to do some minor cleanups from time to time without having to wait (possibly infinitely) for the maintainer's approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants