-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geanypy: Drop use of the most obvious deprecated Geany API #363
Conversation
Also introduce the Document.reload_force() alias to Document.reload_file(), as per non-deprecated Geany API.
LGBI. @elextr I, too, don't know what I'm doing so if there's some other place where the depreciation should be mentioned, please fix it - it's your plugin after all :-P. |
Better push it to upstream codebrainz/geanypy |
@techee its not my plugin, random people who commit stuff to it have just taken over its maintainership. |
See #435 This commit was not approved by the maintainer. |
@elextr OK.
I've previously asked Colomban and Frank if I can merge the Colomban's deprecation-removal patches since they have been lying here for months and the plugin maintainers haven't merged them yet (and most probably won't if they didn't until now), see |
On 9 June 2016 at 23:50, Jiří Techet [email protected] wrote:
As I said in my maintainer resignation, Geany-plugins has become untenable
|
Okay, I didn't get it was a request for this to be acceptable. I'd be happy to add it, I'd just need to know how it should be done. Is there a way to do that further than writing some random sentence? |
@b4n, AFAIK just use text, probably adding something like "[Deprecated, use ...]" would do. |
Sorry. My impression was the maintainers have been pinged enough when the pull request was made and didn't respond for 3 months which I interpreted as either "looks OK" or "don't care about Geany any more".
Sorry, I didn't interpret your message as not approving the patch. Since I know nothing about the plugin I didn't explore where such a docstring belongs. And adding it is quite trivial for someone who does - which I assumed was you. Also my impression was that merging this doesn't break anything and that the docstring patch could be added later quite independently.
Again sorry if merging this and other similar patches looked unfriendly - I definitely didn't want to do something against plugin maintainer's will and didn't expect this reaction. Since many plugins are unmaintained and even when they are officially maintained the maintainers don't respond, I think it's necessary to do some minor cleanups from time to time without having to wait (possibly infinitely) for the maintainer's approval. |
Also introduce the Document.reload_force() alias to Document.reload_file(), as per non-deprecated Geany API.
@codebrainz @elextr