debugger: Fix escaping target executable path if it contains non-ASCII #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDB doesn't like octal escape sequences in executable path passed to `-file-exec-and-symbols`, yet it accepts them (but doesn't require them) in arguments to `-break-insert`. So, use an escaping valid everywhere, as for the moment it's unclear whether there is any benefit to escaping special bytes in argument to `-break-insert`, and so consistency is better. Fixes geany#416.
b4n
added a commit
that referenced
this pull request
Jun 27, 2016
debugger: Fix escaping target executable path if it contains non-ASCII
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDB doesn't like octal escape sequences in executable path passed to
-file-exec-and-symbols, yet it accepts them (but doesn't requirethem) in arguments to
-break-insert.So, use an escaping valid everywhere, as for the moment it's unclear
whether there is any benefit to escaping special bytes in argument to
-break-insert, and so consistency is better.Fixes #416.