geanydoc: Current word as initial text in interactive mode #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dialog = create_Interactive(); | ||
| dialog = create_Interactive(default_word); | ||
| if (default_word) | ||
| g_free(default_word); |
There was a problem hiding this comment.
g_free() (like free()) is NULL-safe, no need to guard it
This makes the plugin more useful for namespaced languages like Python, where you often want to tweak the words a bit (e.g. "xyzzy" -> "somelib.xyzzy") before looking them up.
|
@b4n Fixed, thanks. |
|
Code LGBI, but I don't know the plugin at all. |
|
@b4n I’m not sure what’s the workflow on this project. Should I mail Yura Siamashka, who is listed in MAINTAINERS, and ask him to have a look? |
|
@vfaronov ideally yes he'd have a look at it |
|
@b4n I mailed Yura a couple weeks ago, but he has not responded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the plugin more useful for namespaced languages like Python, where you often want to tweak the words a bit (e.g.
xyzzy→somelib.xyzzy) before looking them up.