Rename GeanyLipsum to just Lipsum #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config_file = g_strconcat(geany->app->configdir, | ||
| G_DIR_SEPARATOR_S, "plugins", G_DIR_SEPARATOR_S, | ||
| "geanylipsum", G_DIR_SEPARATOR_S, "lipsum.conf", NULL); | ||
|
|
||
| #ifndef G_OS_WIN32 | ||
| /* We try only to move if we are on not Windows platform */ | ||
| config_dir_old = g_strconcat(geany->app->configdir, G_DIR_SEPARATOR_S, |
There was a problem hiding this comment.
could use g_build_filename() instead for these.
frlan
force-pushed
the
feature/rename_geanylipsum
branch
from
e565d8a to
a129fc4
Compare
| @@ -1,12 +1,12 @@ | |||
| GeanyLipsum | |||
| Lipsum | |||
| ----------- | |||
There was a problem hiding this comment.
could change the underline length too (not necessary though)
|
Otherwise LGBI |
| if (dialogs_show_question( | ||
| _("Renamed plugin detected!\n" | ||
| "\n" | ||
| "GeanyLipsum has been renamed to Lipsum -- you surely have " |
There was a problem hiding this comment.
as you will have already recognised
frlan
force-pushed
the
feature/rename_geanylipsum
branch
from
a129fc4 to
7f33eb6
Compare
| @@ -0,0 +1,9 @@ | |||
| AC_DEFUN([GP_CHECK_GEANYLIPSUM], | |||
There was a problem hiding this comment.
you could want to rename that (and in the configure.ac too).
|
Otherwise LGBI |
frlan
force-pushed
the
feature/rename_geanylipsum
branch
from
7f33eb6 to
9abd912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for Geany prefix on plugins.