Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Move debug output accessing after check whether err != Null #511

Conversation

frlan
Copy link
Member

@frlan frlan commented Dec 17, 2016

The debug-output is accessing err. If err is Null, it will fail most likely.

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks sensible :)

I'm not fond of the whitespace changes in the same commit, and there's a slight style "issue" (see comment), but I don't mind too much either, so I'll leave the call to you.

if (err)
{
#ifdef DEBUG_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: the preproc directives used not to be indented

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was thinking about whether or not but decided for personal reasons ;)

@b4n b4n assigned b4n and frlan Dec 18, 2016
@b4n b4n added this to the 1.30.0 milestone Dec 18, 2016
@frlan
Copy link
Member Author

frlan commented Dec 18, 2016

I just having Geany configured to purge trailing spaces etc so in the end its all cleaner.

@frlan frlan merged commit c5ec891 into geany:master Dec 18, 2016
@frlan frlan deleted the fix/debugger/prevent_from_possible_nullpointer_dereference branch January 5, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants