Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench: support live update. Closes #659. #695

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

lpaulsen93
Copy link
Contributor

@lpaulsen93 lpaulsen93 commented Feb 17, 2018

With this PR the workbench file list and sidebar will automatically be updated if a file is created, removed or renamed. The feature uses the file monitoring from the GIO lib to monitor directories. If required, the feature can be disabled in the workbench settings dialog.

This requires PR #694.

With this PR the workbench file list and sidebar will automatically be updated
if a file is created, removed or renamed. The feature uses the file monitoring
from the GIO lib to monitor directories. If required, the feature can be
disabled in the workbench settings dialog.
@frlan
Copy link
Member

frlan commented Feb 26, 2018

During running make check I'm getting:

.libs/workbench_la-wb_project.o: In function `wb_project_dir_remove_file':
/home/frlan/quellen/geany-plugins/workbench/src/wb_project.c:701: undefined reference to `gp_filelist_filepath_matches_patterns'
.libs/workbench_la-wb_project.o: In function `wb_project_dir_add_file_int':
/home/frlan/quellen/geany-plugins/workbench/src/wb_project.c:584: undefined reference to `gp_filelist_filepath_matches_patterns'

Also a file is missing inside POTFILES.in

diff --git a/po/POTFILES.in b/po/POTFILES.in
index d88d8a5d..3609b322 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -320,6 +320,7 @@ workbench/src/popup_menu.c
 workbench/src/sidebar.c
 workbench/src/utils.c
 workbench/src/wb_globals.c
+workbench/src/wb_monitor.c
 workbench/src/wb_project.c
 workbench/src/workbench.c

@lpaulsen93
Copy link
Contributor Author

@frlan: yes, it depends on PR #694 which adds the missing function to the utils lib. I placed it in a different PR because it's a different "sub-project" and not the workbench plugin itself.

@frlan frlan merged commit da2dc1e into geany:master Mar 4, 2018
@lpaulsen93 lpaulsen93 deleted the wb-liveupdate branch March 10, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants