[Debugger] Windows port for geany's "debugger" plugin.

[vkochan]

Hi,
This is my 1'st little testable version

[frlan]

Was anybody able to test? Don't have some suitable Windows-setup for testing.

[frlan]

As nobody was able to test it so far, this will be postponed to post 1.24

[frlan]

Any news on this?

[eht16]

I had a quick look.

First, I made the following changes to the Waf build system to properly build and install on Windows:

diff --git a/debugger/wscript_build b/debugger/wscript_build
index 0be873f..25d3126 100644
--- a/debugger/wscript_build
+++ b/debugger/wscript_build
@@ -20,12 +20,12 @@
 #
 # $Id: wscript_build 1735 2010-11-09 17:03:40Z eht16 $

-from build.wafutils import build_plugin
+from build.wafutils import build_plugin, target_is_win32
 from waflib.Utils import subst_vars

 name = 'Debugger'

-includes = ['debugger/src', 'debugger/src/cell_renderers', 
+includes = ['debugger/src', 'debugger/src/cell_renderers',
             'debugger/src/xpm']

 libraries = ['VTE', 'UTIL']
@@ -37,6 +37,9 @@ defines=[ subst_vars('DBGPLUG_DATA_DIR="' + plugin_datadir + '"', bld.env) ]
 build_plugin(bld, name, includes=includes, libraries=libraries, defines=defines)

 # Icons
+prefix = '${G_PREFIX}/' if target_is_win32(bld) else ''
+icon_dest = '%s${PKGDATADIR}/debugger' % prefix
+
 start_dir = bld.path.find_dir('img')
-bld.install_files(plugin_datadir, start_dir.ant_glob('*.png'), cwd=start_dir)
-bld.install_files(plugin_datadir, start_dir.ant_glob('*.gif'), cwd=start_dir)
+bld.install_files(icon_dest, start_dir.ant_glob('*.png'), cwd=start_dir)
+bld.install_files(icon_dest, start_dir.ant_glob('*.gif'), cwd=start_dir)
diff --git a/debugger/wscript_configure b/debugger/wscript_configure
index 2d64484..451a176 100644
--- a/debugger/wscript_configure
+++ b/debugger/wscript_configure
@@ -20,13 +20,13 @@
 #
 # $Id: wscript_configure 1735 2010-11-09 17:03:40Z eht16 $

-from build.wafutils import check_cfg_cached
+from build.wafutils import check_cfg_cached, target_is_win32

+if not target_is_win32(conf):
+   check_cfg_cached(conf,
+                    package='vte',
+                    uselib_store='VTE',
+                    args='--cflags --libs')

-check_cfg_cached(conf,
-                 package='vte',
-                 uselib_store='VTE',
-                 args='--cflags --libs')
-
-conf.check_cc(function_name='poll', header_name='poll.h')
-conf.check_cc(function_name='openpty', header_name='pty.h', lib='util', uselib_store='UTIL')
+   conf.check_cc(function_name='poll', header_name='poll.h')
+   conf.check_cc(function_name='openpty', header_name='pty.h', lib='util', uselib_store='UTIL')

After these changes, the plugin built and loaded fine.

Opening a target and setting breakpoints works fine. However, executing the target in the debugger doesn't work. It seems like some command is exectued because a command line window is popping up but it closes very quickly. Except the following messages, nothing is logged:

14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_string_free: assertion `string != NULL' failed
14:39:19: GLib CRITICAL : g_hash_table_destroy: assertion `hash_table != NULL' failed

[frlan]

@vkochan Can you please review Enrico's suggestions and maybe update your PR?

[vkochan]

Meanwhile I don't have a setup with windows machine, I dropped using windows by default, so I am not
sure if I can help with supporting of this patch.

[frlan]

Am 11.03.2015 um 08:37 schrieb Vadim Kochan:

Meanwhile I don't have a setup with windows machine, I dropped using
windows by default, so I am not
sure if I can help with supporting of this patch.

OK. I keep it open and maybe somebody is able to adopt it.

[frlan]

I will close the MR yet as it's quiet ancient already and nobody seemed to take over.