lipsum: fixed deprecated gtk call for gtk3 #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebrainz
reviewed
May 12, 2019
utils/src/gp_gtkcompat.h
Outdated
| gtk_menu_item_new_with_mnemonic(). Starting from version 3.10.*/ | ||
| #if GTK_CHECK_VERSION(3, 10, 0) | ||
| #define gtk_image_menu_item_new_with_mnemonic(icon_info) \ | ||
| gtk_menu_item_new_with_mnemonic(icon_info) |
There was a problem hiding this comment.
This doesn't seem like a good wrapper for general use in the util library since it returns a different type of widget.
While much more work, it might be better to add some kind of real image menu item replacement class that packs an optional icon and an accel label into a box, similar to the example on the GtkImageMenuItem docs.
There was a problem hiding this comment.
Thanks. But I guess I will then postpone that to a later time when it's really required. Here with lipsum there is no icon used at all. I will do the replacement in the lipsum file directly and remove the macro. If I find a use case later which really uses an icon I will go for your advice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a deprecation warning in the lipsum plugin for gtk3. No functional changes.