Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoclose: fixed deprecated gtk call for gtk3 #857

Merged
merged 1 commit into from
May 16, 2019

Conversation

lpaulsen93
Copy link
Contributor

This fixes a deprecation warning in the autoclose plugin for gtk3. No functional changes.

A little side note:
I first thought I could use gtk_container_add() on gtk 2 and 3 because of this deprecation notice in the gtk documentation:

gtk_scrolled_window_add_with_viewport has been deprecated since version 3.8 and should not be used in newly-written code.
gtk_container_add() will automatically add a GtkViewport if the child doesn’t implement GtkScrollable.

But the function only works that way under gtk3. A test with gtk2 revealed that the function does not work that way with the result that in this case the scroll bar was missing in the autoclose configuration dialog.

@frlan frlan merged commit 69fddd4 into geany:master May 16, 2019
@lpaulsen93 lpaulsen93 deleted the autoclose-gtk3 branch May 16, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants