You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Regarding the feature(panic_info_message): core::panic::PanicInfo implements Display and will format the panic message: panicked at {file}:{line}:{column}:\n{msg}
Current implementation of gstd uses custom format: '{msg}', {file}:{line}:{column}. Should we use #[feature(panic_info_message)] just to implement a custom format of panic message? I think we can parse the String in a standard format and convert it to a custom format instead of requiring nightly toolchain.
Problem to Solve
Do we need nightly features in gstd at all?
Once we merge new allocations and set memory limits to 4GB #3472, out of memory errors will become very rare, so there is no point in
feature(alloc_error_handler)
Regarding the
feature(panic_info_message)
:core::panic::PanicInfo
implementsDisplay
and will format the panic message:panicked at {file}:{line}:{column}:\n{msg}
Current implementation of gstd uses custom format:
'{msg}', {file}:{line}:{column}
. Should we use#[feature(panic_info_message)]
just to implement a custom format of panic message? I think we can parse the String in a standard format and convert it to a custom format instead of requiring nightly toolchain.Possible Solution
Convert the output of
<core::panic::PanicInfo as Display>
to our custom format.It's probably easy, but it's worth considering
Rust <1.73
:Change default panic handler message format. rust-lang/rust#112849
Discussed:
debug
feature:Display
as isdebug
feature: get message fromDisplay
, w/o locationMake our custom format obsolete
Notes
No response
The text was updated successfully, but these errors were encountered: