-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gstd): get panic message without panic_info_message
#3527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still considering best approach here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what have we decided to do with possibility to throw whole display for not(feature(debug))? @StackOverflowExcept1on
And how is it working wout oom-handler and allocation error on stable panic message? It would be good to have some tests maybe
I think it's quite expensive even for the nightly version.
We've already discussed this. On the nightly version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got your point. I'm good with the solution. Awesome work
Please review @ark0f
I'd just print |
@ark0f there are several reasons:
|
Co-authored-by: Arsenii Lyashenko <[email protected]>
🥳 |
Resolves #3524
We are getting closer to
cargo build +stable -p gstd
@gear-tech/dev