Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm-builder): Introduce switch for disabling path remapping #2890

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

DennisInSky
Copy link
Member

@DennisInSky DennisInSky commented Jun 29, 2023

Path remapping makes compilation under WSL terrible. Cold rebuild, i.e. when there were no changes in any examples, takes 9 min compared to 45 sec without that remapping

@reviewer-or-team

@DennisInSky DennisInSky self-assigned this Jun 29, 2023
@DennisInSky DennisInSky added the A0-pleasereview PR is ready to be reviewed by the team label Jun 29, 2023
@StackOverflowExcept1on
Copy link
Member

What version of WSL are you using? You may have an old installation and are not using WSL2.

Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gshep gshep added the D5-tooling Helper tools and utilities label Jun 30, 2023
@DennisInSky
Copy link
Member Author

What version of WSL are you using? You may have an old installation and are not using WSL2.

This is for WSL2. As far as I got it from the conversation with you - we have the same issue on the native Linux

@DennisInSky DennisInSky merged commit 9b59f09 into master Jun 30, 2023
@DennisInSky DennisInSky deleted the dd/wasm-builder-path-remap-switch branch June 30, 2023 08:42
@DennisInSky DennisInSky removed the A0-pleasereview PR is ready to be reviewed by the team label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D5-tooling Helper tools and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants