-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime, ci): finish migration to bare-metal benchmark runner and update weights #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90ad5ed
to
734aecb
Compare
c624131
to
7cd88a9
Compare
ByteNacked
commented
Jun 4, 2024
4c2c58d
to
b0bddd1
Compare
Should |
breathx
approved these changes
Jun 11, 2024
Unnecessary, it's all up to you, on release tagging I'll anyway double check all versions |
Please resolve master brach conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
A migration of the benchmark runner was performed, moving from a virtual host to a bare-metal host to increase the reproducibility of benchmark results.
Since the bare-metal host differs somewhat in performance from the equivalent virtual host, we investigated these differences through several benchmark runs and calculated the average discrepancy between them. As a result, a 10% adjustment was introduced to the instruction weights, aligning the instruction weight results with those on the virtual host.
Additionally, for the multi-threaded benchmarks of the
gear_builtin
pallet, it was decided to fix the execution of these benchmarks to 4 CPU cores, again to improve the reproducibility of the results.pallet_gear_builtin
) on fixed number of cores (4 cores)@reviewer-or-team