Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for endPosition per ECMA262? #2

Open
acagastya opened this issue Oct 1, 2020 · 0 comments · May be fixed by #3
Open

Support for endPosition per ECMA262? #2

acagastya opened this issue Oct 1, 2020 · 0 comments · May be fixed by #3

Comments

@acagastya
Copy link

The ECMA-262 spec has an optional endPosition parameter.

Which means "abcde".endsWith('d', 4) // true -- however this is not currently supported. It is possible to add that feature without non-breaking change.

Please consider adding that support.
acagastya added a commit to acagastya/end-with that referenced this issue Oct 1, 2020
@acagastya
Making it ECMA-262 compliant + fixes gearcase#2
18c7457
@acagastya acagastya linked a pull request Oct 1, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add endPosition support as per ECMA-262 acagastya/end-with
1 participant
@acagastya