Fix CRU #67
Merged
Fix CRU #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. it should return consistenly a data.frame containing columns "sitename","lon","lat",nested("varnam","date","value") (if get_time==TRUE for cases WFDEI and CRU) and columns "sitename","lon","lat",nested("varnam","value") (otherwise)
Since "ndep" also relies on extract_pointdata_allsites(get_time = TRUE) this commit ensures it remains functional with the previous changes in extract_pointdata_allsites()
fabern
added a commit
that referenced
this pull request
Dec 6, 2024
CRU downscaling from monthly to daily was done wrongly for multiple sites. This now fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the package to make it run again for CRU data, since daily downscaled CRU data are required for BiomeE simulations.
extract_pointdata_allsites()to work with CRU data)