Add ppfd and patm computation to CRU #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code requires all four columns: year_start, year_end, as well as date_start, date_end Since it is possible to only provide two of them, the others need to be derived. The code previously was difficult to understand. This now simplifies the intent. We also add a test in the unlikely case where all four are provided, but they are inconsistent.
Previously numerous if-statements lead to replication of code. This simplifies the logic and better documents intent with code comments.
Since VPD is recomputed anyway on daily resolution it is not taken care of by `expand_clim_cru_monthly_byyr()`, i.e. it silently drops that column. More robust is if the column is kept and daily values are initialized as NA. This is done by this commit. Moreover, the data.frame() after recomputing VPD is now ungrouped, since this is less errror-prone.
…arameters and geometric relationships
…e end of function
… the end of function This reduces code duplication and is similar to how it is handled for ppfd or patm
This is not needed anymore, since vpd is now computed after downscaling in any case.
|
@fabern , Thanks! On your points:
May I add a point?
|
|
Ok, I will have a look at Below is the comparison between Note how WorldClim is only between 35 to 80% of the computed value ( |
|
When using the daily downscaled cloud cover from CRU to compute, the bias with WorldClim disappears. (See below 'scale' of the monthly averages is around 1.0.)
|
…RU to compute ppfd or patm.
|
I have now updated the vignette. The computed PPFD look alright compared with fluxnet data from CH-Lae. (Albeit the monthly bias-correction introduces discontinuous steps between months. See the jump between June/July 2012 in the red line, not present in the blue line.)
|
R CMD Check warned: "ingest: possible error in all_of(siteinfo, sitename, lon, lat): unused arguments (sitename, lon, lat)"
|
@stineb This is now ready for review. In a nutshell this PR:
|
|
Thanks @fabern . We'll eventually have to remove all use of {rgdal} as the library is discontinued. This means also that we'll have to replace all use of the {raster}, now using {terra}. There might be some places left where raster is used, these should eventually be changed. |
|
I'm going ahead with the merge anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds computation of
ppfdandpatm, when ingesting CRU data.Since neither
ppfdnorpatmare measured variables in CRU they are derived in the following way:patm: using the elevation of the site only.calc_patm(elv, patm0 = 101325), which assumes normal pressure at sea levelppfd: usingcalc_daily_solar(),ppfdis thus computed based on geometric relationships (sunrise, sunset, etc...) given the (time-varying up to 1'000'000 BC) orbital parameters of earth. Note that this strongly assumes sunshine fraction of1.0, i.e. it is not only "always sunny in philadelphia" but on the whole world.1.0could be improved by linking it to the number of wet daysmwetd(since it is available from CRU) for which this could be set to0.0@stineb do you think would make a difference?sf = 1 - (ccov/100))