Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params_species (in both BiomeE example drivers) is needlessly filled up to 16 rows #267

Closed
2 tasks
fabern opened this issue Nov 28, 2024 · 0 comments · Fixed by #270
Closed
2 tasks

params_species (in both BiomeE example drivers) is needlessly filled up to 16 rows #267

fabern opened this issue Nov 28, 2024 · 0 comments · Fixed by #270

Comments

@fabern
Copy link
Member

fabern commented Nov 28, 2024

params_species is needlessly filled up to 16 rows.
This concerns both: biomee_gs_leuning_drivers and biomee_p_model_drivers

The reasons was that historically only 16-row data.frames were valid input into the Fortran code.
This has been mitigated in the meantime.

  • I suggest now, that params_species in both example drivers are reduced to the first four distinct rows.
    (Even though only the second vegetation type is then initialized as specified by biomee_p_model_drivers$init_cohort.)
library(rsofun)
library(dplyr)
library(tidyr)

# params_species <- rsofun::biomee_gs_leuning_drivers$params_species[[1]]
params_species <- rsofun::biomee_p_model_drivers$params_species[[1]]
params_species |> distinct()                                       #actually only 4 out of 16 rows are distinct
params_species |> distinct() |> select(where(~ n_distinct(.) > 1)) #showing the 4 properties where the 4 rows are distinct
params_species |> select(where(~ n_distinct(.) > 1))               #showing the 4 properties across all 16 rows
#                                                                  #the 4 properties are: phenotype, thetaBM, LMA, rho_wood
  • Moreover, update of the documentation ?biomee_gs_leuning_drivers is needed.
    There only the following columns of init_cohort are documented: init_cohort_species, init_cohort_nindivs, init_cohort_bsw, init_cohort_bHW, init_cohort_nsc, thus missing are init_n_cohorts, init_cohort_bl, init_cohort_br, init_cohort_seedC
@marcadella marcadella linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant