Simplify biomee drivers #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marcadella
commented
Dec 2, 2024
marcadella
commented
- Reduce size of params_species in biomee drivers
- Reduce size of init_cohort in biome driver
- First column of biomee drivers is now ignored (the number of initial cohorts is given by the array itself). For safety, this column must be set to 0.
- Update documentation
- Reduce size of init_cohort in biome driver - First column of biomee drivers is now ignored (the number of initial cohorts is given by the array itself). For safety, this column must be set to 0. - Update documentation
2 tasks
…drivers-is-needlessly-filled-up-to-16-rows
fabern
reviewed
Dec 2, 2024
R/run_biomee_f_bysite.R
Outdated
|
|
||
| if (registered_n_cohorts != 0) { | ||
| warning( | ||
| sprintf("Error: init_cohorts' init_cohort_species is deprecated and should contain a negative value (found %i)", |
R/run_biomee_f_bysite.R
Outdated
| @@ -343,6 +343,15 @@ run_biomee_f_bysite <- function( | |||
| return(TRUE) | |||
| } | |||
| }) | |||
|
|
|||
| registered_n_cohorts <- init_cohort$init_n_cohorts[[1]] | |||
There was a problem hiding this comment.
The 0 is just a temporary safety solution to avoid a breaking change, right? At the same time it is actually breaking the code anyway.
Should we really use this numeric checking?
It seems simpler to make a check for the element names and if init_n_cohorts is found just emit a warning and append FALSE to data_integrity.
- Detect 'init_n_cohorts' and emit a warning when present.
fabern
reviewed
Dec 3, 2024
R/data.R
Outdated
| #' \item{init_cohort_bsw}{Initial biomass of sapwood, in kg C per individual.} | ||
| #' \item{init_cohort_bHW}{Initial biomass of heartwood, in kg C per tree.} | ||
| #' \item{init_cohort_bHW}{Initial biomass of heartwood, in kg C per individual.} | ||
| #' \item{init_cohort_seedC}{Initial biomass of seed, in kg C per individual.} | ||
| #' \item{init_cohort_nsc}{Initial non-structural biomass.} |
There was a problem hiding this comment.
Is the NSC biomass also in kg C per individual?
fabern
approved these changes
Dec 3, 2024
marcadella
deleted the
267-params_species-in-both-biomee-example-drivers-is-needlessly-filled-up-to-16-rows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.