-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.3.0 version slow on Windows #416
Comments
I can confirm this slow down. pg-1.3.0-rc3 is slower by a factor of 5 to 10 than pg-1.2.3 on Windows. I guess it's due to #397 , which changed quite a lot in the socket handling code. Now the Windows socket code is no longer a separate path, but is equal to the Posix code. Both are using the same ruby functions for READ/WRITE event notifications on the network socket. This is |
It is based on the code that was removed in commit ged@6c885e8 Fixes ged#416
It is based on the code that was removed in commit ged@6c885e8 Fixes ged#416
It is based on the code that was removed in commit ged@6c885e8 Fixes ged#416
It is based on the code that was removed in commit ged@6c885e8 Fixes ged#416
It is based on the code that was removed in commit ged@6c885e8 Fixes ged#416
I pushed a new pre-release pg-1.3.0.rc4, which should fix this performance issue. |
That was fast! Performance issue seems to be fixed, thanks Lars. |
This is my environment:
Rails 6.1.4.4
Ruby 2.7.4
PostgreSQL 12.6
OS Windows 10
PG gem 1.2.3 is working fine for me, but it does not support ruby 3. So I upgraded to the latest version 1.3.0.rc3. It installed without complaints and the rails app runs ok. I noticed some slowness so I compared 1.2.3 against 1.3.0 and the latter is really slow.
For our main page which does nothing rare, standard selects it went from 120ms to 600ms, same results for other pages. This is a 5x performance hit. Maybe 1.3.0 is not yet optimized for windows.
This is currently blocking our upgrade to ruby 3.
The text was updated successfully, but these errors were encountered: