Save connection options for conn.reset #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskanis
force-pushed
the
fix-host-dup-on-reset
branch
2 times, most recently
from
9af679a to
0c8fcd1
Compare
Commit 016c17c introduced a regression, that leads to a host list duplication every time conn.reset is used. Since the hosts are duplicated when resolve_hosts is called, the conn.coninfo_hash can not be used. So the fix is to store the original hash of connection options for later use in conn.reset . Fixes ged#586
larskanis
force-pushed
the
fix-host-dup-on-reset
branch
from
0c8fcd1 to
bf7d57f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 016c17c introduced a regression, that leads to a host list duplication every time
conn.resetis used.Since the hosts are duplicated when resolve_hosts is called, the
conn.coninfo_hashcan not be used. So the fix is to store the original hash of connection options for later use in conn.reset .Fixes #586