Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: #1076 #1080

Merged
merged 1 commit into from
Mar 23, 2024
Merged

fixbug: #1076 #1080

merged 1 commit into from
Mar 23, 2024

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Mar 23, 2024

Features
fixbug: #1076

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (933a242) to head (89b263a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   81.35%   81.16%   -0.19%     
==========================================
  Files         248      248              
  Lines       13883    13885       +2     
==========================================
- Hits        11294    11270      -24     
- Misses       2589     2615      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation may still be flawed because it directly overrides the underlying method, which is not recommended behavior.

@geekan geekan merged commit ac755e7 into geekan:main Mar 23, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants