Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: gbk UnicodeEncodeError #973

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Mar 7, 2024

Features

  • Due to the absence of a specified character set, the function for saving files used the system's default character set, gbk, to save files. However, the Unicode character "\u27f6" does not have a corresponding character in gbk, resulting in a character set conversion exception being raised.
  • The modified file read/write operations now uniformly adopt the utf-8 character set. In cases where a character set exception is encountered while reading files, adaptive character set detection logic has been added.

Issue
img_v3_028o_c17ff164-6c18-4475-8ae3-e78e535f6dfg

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.18%. Comparing base (fe9dae1) to head (9d325d4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.7-release     #973   +/-   ##
=============================================
  Coverage         81.18%   81.18%           
=============================================
  Files               226      226           
  Lines             12482    12483    +1     
=============================================
+ Hits              10133    10134    +1     
  Misses             2349     2349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geekan geekan merged commit 283c7b4 into geekan:v0.7-release Mar 8, 2024
1 of 3 checks passed
@iorisa iorisa added the bug-fix label Mar 21, 2024
@iorisa iorisa mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants