Dont print diff when config is changeing #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially when using bindpw this should not be printed in plaintext also when bindpw will printed in plaintext, this will be stored plaintext in the report
|
Hello, thanks for the PR. I will merge it soon and upload a new version of the module =) |
|
Hello, thanks again for the PR. I've added a new parameter for the module : config_show_diff which is set to false by default. |
|
Great, thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
we are using the nslcd::ldap_bindpw and when changing the bindpw it is printed in the default output and also writting into the report in plaintext.
To prevent this just use show_diff => false ( default true ) in the config file resource.