Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard constraint on context arg in Frankenstein class #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdmct
Copy link
Contributor

@pdmct pdmct commented Nov 11, 2024

This removes the hard constraint on the Frankenstein class.
It checks for the presence of "context" before using it to get the implementations, thus allowing a component to be created without the context (if so desired).

This is necessary to get some experiments with basilisp working among other things (and shouldn't affect any existing functionality), as the context is required to be a positional arg in the constructor to avoid name munging difficulties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant