Followup #91: Add filename option nginx_vhosts
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxyc
changed the title
vhost_filename option.filename option nginx_vhosts
geerlingguy
reviewed
Jun 3, 2017
|
|
||
| - name: Install dependencies. | ||
| package: name=curl | ||
| package: name=curl state=present |
|
I like this option more—it is nice having the server configs broken out into separate files, and this allows that to happen with multiple server definitions for the same domain. |
This was referenced Jun 3, 2017
h3po
pushed a commit
to h3po/ansible-role-nginx
that referenced
this pull request
Aug 13, 2020
Followup geerlingguy#91: Add `filename` option `nginx_vhosts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One solution of how we could fix the problem brought forward here #91 (comment). Currently it's not possible to create a redirect from http -> https as the domain names would be identical and therefore the second vhost file would overwrite the first one.
I also improved the README example so it shows a more advanced, but very common scenario where you want to redirect all http traffic to https, as well as redirect www.example.com to example.com.
Any better ideas?