adding yum repo flag for Redhat #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In environments where RHEL uses Satellite or production servers can't reach out to the internet, and the Yum repo is not wanted. This commit adds a flag to disable the functionality. It also removes the enablerepo: nginx line from the package since a) it's redundant and b) working around it overly complicates the situation.
|
Looks good to me. Will need to test a little further before merging and adding to a tagged release (I want to verify that the enablerepo change doesn't break existing builds when upgrading). |
|
Let me know what I can do to help- the template for the nginx repo has enablerepo=1 right in it, so hopefully it shouldn't cause any complications. |
|
You're quite correct! https://github.com/geerlingguy/ansible-role-nginx/blob/master/templates/nginx.repo.j2#L5 I guess I should look there before questioning your statement :) |
geerlingguy
added a commit
that referenced
this pull request
Jan 25, 2017
|
This is in 1.9.7, as it's not a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In environments where RHEL uses Satellite or production servers can't
reach out to the internet, and the Yum repo is not wanted. This commit
adds a flag to disable the functionality. It also removes the
enablerepo: nginx line from the package since a) it's redundant and b)
working around it overly complicates the situation.