Fix classic notebook extension installation (#110)

* fix classic notebook js extension path nbextension/static -> nbextension/ * update release notes * clean-up
geigr · Apr 28, 2023 · 6a9e2c9 · 6a9e2c9
1 parent 8214d14
commit 6a9e2c9
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 20 deletions.
diff --git a/.gitignore b/.gitignore
@@ -147,7 +147,7 @@ $RECYCLE.BIN/
 # ----
 
 **/node_modules/
-ipytone/nbextension/static/index.*
+ipytone/nbextension/index.*
 ipytone/labextension/*.tgz
 .yarn/
 

diff --git a/docs/release_notes.rst b/docs/release_notes.rst
@@ -5,6 +5,15 @@
 Release Notes
 =============
 
+v0.5.1
+------
+
+Bug fixes
+~~~~~~~~~
+
+- Fixed installation issue with notebook "classic" version <7 (:issue:`109`,
+  :pull:`110`).
+
 v0.5.0
 ------
 

diff --git a/ipytone/nbextension/__init__.py b/ipytone/nbextension/__init__.py
diff --git a/ipytone/nbextension/static/extension.js → ipytone/nbextension/extension.js b/ipytone/nbextension/static/extension.js → ipytone/nbextension/extension.js
diff --git a/pyproject.toml b/pyproject.toml
@@ -60,7 +60,7 @@ Homepage = "https://github.com/benbovy/ipytone"
 
 [tool.hatch.build]
 artifacts = [
-    "ipytone/nbextension/static/index.*",
+    "ipytone/nbextension/index.*",
     "ipytone/labextension/*.tgz",
     "ipytone/labextension",
 ]
@@ -79,11 +79,11 @@ exclude = [
 [tool.hatch.build.hooks.jupyter-builder]
 build-function = "hatch_jupyter_builder.npm_builder"
 ensured-targets = [
-    "ipytone/nbextension/static/index.js",
+    "ipytone/nbextension/index.js",
     "ipytone/labextension/package.json",
 ]
 skip-if-exists = [
-    "ipytone/nbextension/static/index.js",
+    "ipytone/nbextension/index.js",
     "ipytone/labextension/package.json",
 ]
 dependencies = [

diff --git a/webpack.config.js b/webpack.config.js
@@ -27,7 +27,7 @@ module.exports = [
     entry: './src/extension.ts',
     output: {
       filename: 'index.js',
-      path: path.resolve(__dirname, 'ipytone', 'nbextension', 'static'),
+      path: path.resolve(__dirname, 'ipytone', 'nbextension'),
       libraryTarget: 'amd',
     },
     module: {