Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Move breadcrumb json configuration to viewmodel #36

Merged
merged 435 commits into from
Jun 30, 2018
Merged

[Forwardport] Move breadcrumb json configuration to viewmodel #36

merged 435 commits into from
Jun 30, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15521

Description

Move breadcrumb json configuration to viewmodel and serialize it using Magento json serializer
Tweak code motivated by discussion in pull request magento#15162

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Saurabh Parekh and others added 30 commits June 19, 2018 04:21
Correct return type of methods and typo correction.
57b9cd2
bool primitive type in return type
bd15eb3
@orlangur
Remove unneeded class import
3000eac
@tejashkumbhare @tejash-wagento
Navigation dropdown caret icon.
849d23d
@sanganinamrata
Removed unnecessary blank line from xml.
f4912a2
@sanganinamrata
Fixed syntax for before-after operators in less files.
b01a948
@sanganinamrata
Correct sentence in comment section in class file.
010b16f
@DianaRusin
MAGETWO-92007: A first few ui_component labels are removing on Add li…
492e81e 
…nk action
@magento-engcom-team
ENGCOM-2038: Navigation dropdown caret icon. magento#16225
9777137 
 - Merge Pull Request magento#16225 from tejash-wagento/magento2:2.3-develop-PR-port-16082
 - Merged commits:
   1. 849d23d
@zakdma
Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-pr24
d934010
@zakdma
Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-92826
8e05035
@zakdma
Merge remote-tracking branch 'origin/MAGETWO-92826' into 2.3-develop-…
c40cafa 
…pr24
@zakdma
MAGETWO-92308: Wrong price and Cart Subtotal at mini shopping cart
1525c69
@magento-engcom-team
ENGCOM-2043: [Forwardport] Correct return type of methods and typo co…
c8e7c0c 
…rrection. magento#16224

 - Merge Pull Request magento#16224 from saurabh-aureate/magento2:2.3-develop-PR-port-15993
 - Merged commits:
   1. 57b9cd2
   2. bd15eb3
   3. 3000eac
@rogyar
Added integration test for checking admin login attempts cleanup
9912388
@rogyar
Missing copyrights added
5bf729c
@lfluvisotto
array_push(...) calls behaving as '$array[] = ...', $array[] = works …
a34c148 
…faster than invoking functions in PHP
@nmalevanec
1164: OnePageCheckoutOfflinePaymentMethodsTest rework to support MSI …
6be8f8c 
…reservation mechanism.
@tomreece
MC-168: Admin should be able to assign attributes to an attribute set
8271e93 
- Rename duplicate element that broke PageBuilder tests
@tomreece
Merge remote-tracking branch 'origin/2.3-develop' into RE-develop-pr
fea2d9d
@slavvka
Merge remote-tracking branch 'mainline/2.3-develop' into DEVOPS-2632-2.3
6794646
@danielrenaud
MAGETWO-91734: Cannot cancel guest order paid with gift card
900824e 
- Add functional test
Merge remote-tracking branch 'upstream/2.3-develop' into MAGETWO-91545
4b9ccba
@slavvka
DEVOPS-2632: Sample Data Builds Migrated from Bamboo
39b1462
@tomreece
Merge branch '2.3-develop' into RE-develop-pr
4933bb9
@shiftedreality
MAGETWO-92877: Write Core Application Logs to Syslog
79bd644
@shiftedreality
MAGETWO-92877: Write Core Application Logs to Syslog
aec7fa3
@dthampy
MAGETWO-91545: Error not found page issue in change status and update…
7d536c3 
… attribute from product grid

- fixed static failure
merge magento/2.3-develop into magento-borg/MAGETWO-91545
2f09370
merge magento/2.3-develop into magento-borg/DEVOPS-2632-2.3
3422dae
vrann and others added 28 commits June 26, 2018 15:39
@vrann
Merge remote-tracking branch 'comwrap/async-status-search' into bulk-…
7a6c902 
…status-search
@vrann
Merge pull request magento#2765 from magento-engcom/bulk-custom-route
c41ffe5 
Bulk custom route
@vrann
magento/bulk-api-ce#12: Operations Status Search API Endpoint
a17c1fa
@vrann
Merge remote-tracking branch 'mainline/2.3-develop' into status-searc…
e35695a 
…hapi
@vrann
magento/bulk-api-ce#12: Operations Status Search API Endpoint
f67a1e3
@vrann
magento/bulk-api-ce#12: Operations Status Search API Endpoint
ed95acd
add description for new classed/interfaces, remove not duplicated int…
5d7b3ca 
…erface, remove meaningless code
@vrann
magento/bulk-api-ce#12: Operations Status Search API Endpoint
8412217
@vrann
Merge remote-tracking branch 'comwrap/async-status-search' into bulk-…
054f22f 
…status-search

# Conflicts:
#	app/code/Magento/AsynchronousOperations/Api/Data/OperationSearchResultsInterface.php
#	app/code/Magento/AsynchronousOperations/Model/OperationRepository.php
@vrann
Merge remote-tracking branch 'comwrap/async-status-search' into bulk-…
9bd966f 
…status-search

# Conflicts:
#	app/code/Magento/AsynchronousOperations/Api/Data/OperationSearchResultsInterface.php
#	app/code/Magento/AsynchronousOperations/Model/OperationRepository.php
@vrann
Merge remote-tracking branch 'bulk/bulk-status-search' into status-se…
ef60eb2 
…archapi
merge magento/2.3-develop into magento-borg/MAGETWO-86795
ad68d7e
merge magento/2.3-develop into magento-obsessive-owls/MC-401-remove-a…
9cc2c04 
…dvanced-attributes
@irenelagno
Merge pull request magento#2741 from magento-borg/MAGETWO-86795
0339078 
[borg] MAGETWO-86795: Admin Create Customer functional test fails
@tjwiebell
Merge remote-tracking branch 'mainline/2.3-develop' into MC-401-remov…
b80f894 
…e-advanced-attributes
@vrann
Merge remote-tracking branch 'origin/2.3-develop' into status-searchapi
ae1a034
@vrann
magento/bulk-api-ce#12: Operations Status Search API Endpoint
910eaca
@vrann
magento/bulk-api-ce#12: Operations Status Search API Endpoint
2a3c1ad
@tomreece
Merge remote-tracking branch 'mainline/2.3-develop' into RE-develop-pr
96885cb
@tjwiebell
Merge pull request magento#2764 from magento-obsessive-owls/MC-401-re…
168ecf4 
…move-advanced-attributes

[obsessive] MC-401: Advanced Attributes Not Removing From Preview
@vrann
Merge remote-tracking branch 'mainline/2.3-develop' into status-searc…
8d75e92 
…hapi
@tomreece
Merge remote-tracking branch 'mainline/2.3-develop' into RE-develop-pr
0525263
@vrann
Merge pull request magento#2769 from magento-engcom/status-searchapi
ce48579 
Status Search API
@tomreece
Merge remote-tracking branch 'mainline/2.3-develop' into RE-develop-pr
aee9de9
@okolesnyk
Merge pull request magento#2763 from magento-pangolin/RE-develop-pr
f947cad 
[pangolin] Weekly RE-develop functional tests
@diedburn @gelanivishal
Move breadcrumb json configuration to viewmodel
cc5c33b
@gelanivishal
Added escape text.
ce39035
@tdgroot @gelanivishal
Make new Json dependency backwards compatible
35ce945
@gelanivishal gelanivishal merged commit 4ae35c1 into 2.3-develop Jun 30, 2018
gelanivishal pushed a commit that referenced this pull request Aug 11, 2018
@vital-pantsialeyeu
Merge pull request #36 from magento-epam/SPRINT-1-MAGETWO-91500
e5f3a62 
Sprint 1 magetwo 91500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.