This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
Deactivate Submit if Deadline is Over #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 7, 2018 01:12
…ansalted date presentation. remove not nice deadline colors.
#964-code-kata-hide-submit
kesselb
reviewed
Dec 9, 2018
added 3 commits
December 10, 2018 11:25
…ined fontsize "small" for deadline
kesselb
reviewed
Dec 10, 2018
added 8 commits
December 10, 2018 20:19
…om/geli-lms/geli into feature/#964-code-kata-hide-submit
#964-code-kata-hide-submit
kesselb
reviewed
Dec 17, 2018
| @@ -56,12 +56,10 @@ import {TranslationErrorService} from './shared/services/translation-error.servi | |||
| import {MissingTranslationHandler} from '@ngx-translate/core'; | |||
|
|
|||
| // AoT requires an exported function for factories | |||
| export function HttpLoaderFactory(http: HttpClient) { | |||
| export function TranslateHttpLoaderFactory(http: HttpClient) { | |||
There was a problem hiding this comment.
I'm not against this change but why is this part of this pull request?
There was a problem hiding this comment.
good question. Because I stumbled over it, changed it quickly and no longer thought about it :)
There was a problem hiding this comment.
shall I remove this?
added 5 commits
December 17, 2018 17:06
…om/geli-lms/geli into feature/#964-code-kata-hide-submit
dboschm
changed the title
kesselb
approved these changes
Dec 19, 2018
kesselb
force-pushed
the
feature/#964-code-kata-hide-submit
branch
from
c9f43a1 to
44fe4de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #964 and some other deadline stuff
Improvements