Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Migrate MatSnackBar to SnackBarService #2 #730

Merged
merged 8 commits into from
May 14, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 9, 2018

Description:

Closes #574

Migrate MatSnackBar to SnackBarService. There are still some places with MatSnackBar around but its easier to migrate in small steps.

Again without additional issue. This pr is still related to #574 and i guess its easier to keep track when linked to the original issue.

Improvements

  • Migrate MatSnackBar to SnackBarService
  • Refactor some places to async/await

Known Issues:

  • There are still some places with MatSnackBar around (but most of them should be gone withhin the next weeks because other teams an working on this places. e.g. big unit refactoring, whitelist user improvments, etc.)

@kesselb kesselb changed the title WIP: Migrate MatSnackBar to SnackBarService #2 Migrate MatSnackBar to SnackBarService #2 May 9, 2018
@coveralls
Copy link

coveralls commented May 9, 2018

Coverage Status

Coverage remained the same at 65.608% when pulling 908b020 on feature/574-snackbar-migration2 into a9a27e6 on develop.

Copy link
Collaborator

@PatrickSkowronek PatrickSkowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work

Copy link
Collaborator

@PatrickSkowronek PatrickSkowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work

@PatrickSkowronek PatrickSkowronek merged commit 276743a into develop May 14, 2018
@PatrickSkowronek PatrickSkowronek deleted the feature/574-snackbar-migration2 branch May 14, 2018 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants