Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Make e2e login test more stable #823

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 20, 2018

Description:

End to end test for api fails randomly.

Improvements

Wait for http requests before looking for response text.

@kesselb kesselb force-pushed the feature/make-test-suite-more-stable branch from 541d968 to ba6076d Compare August 20, 2018 22:45
@coveralls
Copy link

coveralls commented Aug 20, 2018

Pull Request Test Coverage Report for Build 2793

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 75.415%

Files with Coverage Reduction New Missed Lines %
api/src/models/progress/Progress.ts 2 93.75%
api/src/models/progress/TaskUnitProgress.ts 12 56.25%
Totals Coverage Status
Change from base Build 2779: 0.5%
Covered Lines: 1650
Relevant Lines: 2115

💛 - Coveralls

Copy link
Collaborator

@PatrickSkowronek PatrickSkowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PatrickSkowronek PatrickSkowronek merged commit d14c240 into develop Aug 21, 2018
@kesselb kesselb deleted the feature/make-test-suite-more-stable branch August 21, 2018 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants