Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Exclude dependabot from changelog.md check #854

Merged
merged 9 commits into from
Oct 29, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 17, 2018

Description:

We decided to use https://dependabot.com for dependency updates. dependabot is not able to add a new line to changelog.md. Its required to exclude pull requests from dependabot from changelog.md check.

Improvements

Known Issues:

NONE

@kesselb kesselb added the infrastructure This is not code related, docker, batches etc. label Oct 17, 2018
@kesselb kesselb force-pushed the feature/noid/exclude-dependabot-from-changelog branch 2 times, most recently from 3884c2e to 60d2e6a Compare October 17, 2018 15:36
@aeimer
Copy link
Collaborator

aeimer commented Oct 17, 2018

@danielkesselberg should work. I have some little adaption I would like to see fixed. Give me time until tomorrow

.travis/changelog.sh Show resolved Hide resolved

echo
echo "+++ Check if changelog was updated +++"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use echo the show what will executed, even when there will nothing to be executed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo -e "${YELLOW}+ Pull Request but not against develop or master. No update for CHANGELOG.md required."
exit 0

Default case when a pull request. Every other case is covered.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on @PatrickSkowronek side, we always print the task we do on the first line. We should with this tradition. Makes sense in the travis log

@PatrickSkowronek
Copy link
Collaborator

We have a convention in the shell files, which @danielkesselberg properly not really know? Please add it. The rest looks good, but I would test it locally.

aeimer
aeimer previously requested changes Oct 17, 2018
Copy link
Collaborator

@aeimer aeimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the shell code style we have used in all the other files

.travis/changelog.sh Show resolved Hide resolved

echo
echo "+++ Check if changelog was updated +++"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on @PatrickSkowronek side, we always print the task we do on the first line. We should with this tradition. Makes sense in the travis log

.travis/changelog.sh Show resolved Hide resolved

if [[ ${TRAVIS_PULL_REQUEST} == false ]]; then
echo -e "${GREEN}+ Skip changelog check (no pull request)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always end with ${NC} if you define a color before

curl --silent https://raw.githubusercontent.com/geli-lms/geli/$TRAVIS_BRANCH/CHANGELOG.md \
if [[ ${TRAVIS_BRANCH} == "develop" ]]; then
echo "+ Pull Request from ${TRAVIS_PULL_REQUEST_BRANCH} to ${TRAVIS_BRANCH}"
curl --silent https://raw.githubusercontent.com/geli-lms/geli/"${TRAVIS_BRANCH}"/CHANGELOG.md \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to use " do it with the whole param: curl --silent "https://raw.githubusercontent.com/geli-lms/geli/${TRAVIS_BRANCH}/CHANGELOG.md"

.travis/changelog.sh Show resolved Hide resolved
@kesselb kesselb requested a review from MichaelNarkus October 20, 2018 19:42
@kesselb kesselb force-pushed the feature/noid/exclude-dependabot-from-changelog branch from d9a104f to 0727137 Compare October 20, 2018 19:47
@coveralls
Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 243

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 74.841%

Totals Coverage Status
Change from base Build 241: 1.3%
Covered Lines: 1748
Relevant Lines: 2236

💛 - Coveralls

@kesselb
Copy link
Contributor Author

kesselb commented Oct 25, 2018

@PatrickSkowronek @aeimer apart from your suggestions, you're seeing some problems with the functionality?

@aeimer
Copy link
Collaborator

aeimer commented Oct 26, 2018

@danielkesselberg yeah should work, you propably need to merge and try it...

@dboschm dboschm self-requested a review October 29, 2018 19:10
Copy link
Collaborator

@dboschm dboschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blocking change requests are very tiny and additionally a matter of taste. For me the changes are very nice implemented the way they are.

@kesselb kesselb dismissed aeimer’s stale review October 29, 2018 20:28

We deceided against your requested changes

@kesselb kesselb dismissed PatrickSkowronek’s stale review October 29, 2018 20:28

We deceided against your requested changes

@kesselb kesselb merged commit 1a73037 into develop Oct 29, 2018
@kesselb kesselb deleted the feature/noid/exclude-dependabot-from-changelog branch October 29, 2018 20:35
@kesselb
Copy link
Contributor Author

kesselb commented Oct 29, 2018

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infrastructure This is not code related, docker, batches etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants