-
Notifications
You must be signed in to change notification settings - Fork 70
Exclude dependabot from changelog.md check #854
Exclude dependabot from changelog.md check #854
Conversation
3884c2e
to
60d2e6a
Compare
@danielkesselberg should work. I have some little adaption I would like to see fixed. Give me time until tomorrow |
.travis/changelog.sh
Outdated
|
||
echo | ||
echo "+++ Check if changelog was updated +++" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use echo the show what will executed, even when there will nothing to be executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 54 to 55 in 60d2e6a
echo -e "${YELLOW}+ Pull Request but not against develop or master. No update for CHANGELOG.md required." | |
exit 0 |
Default case when a pull request. Every other case is covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on @PatrickSkowronek side, we always print the task we do on the first line. We should with this tradition. Makes sense in the travis log
We have a convention in the shell files, which @danielkesselberg properly not really know? Please add it. The rest looks good, but I would test it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the shell code style we have used in all the other files
.travis/changelog.sh
Outdated
|
||
echo | ||
echo "+++ Check if changelog was updated +++" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on @PatrickSkowronek side, we always print the task we do on the first line. We should with this tradition. Makes sense in the travis log
.travis/changelog.sh
Outdated
|
||
if [[ ${TRAVIS_PULL_REQUEST} == false ]]; then | ||
echo -e "${GREEN}+ Skip changelog check (no pull request)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always end with ${NC} if you define a color before
.travis/changelog.sh
Outdated
curl --silent https://raw.githubusercontent.com/geli-lms/geli/$TRAVIS_BRANCH/CHANGELOG.md \ | ||
if [[ ${TRAVIS_BRANCH} == "develop" ]]; then | ||
echo "+ Pull Request from ${TRAVIS_PULL_REQUEST_BRANCH} to ${TRAVIS_BRANCH}" | ||
curl --silent https://raw.githubusercontent.com/geli-lms/geli/"${TRAVIS_BRANCH}"/CHANGELOG.md \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to use " do it with the whole param: curl --silent "https://raw.githubusercontent.com/geli-lms/geli/${TRAVIS_BRANCH}/CHANGELOG.md"
d9a104f
to
0727137
Compare
@PatrickSkowronek @aeimer apart from your suggestions, you're seeing some problems with the functionality? |
@danielkesselberg yeah should work, you propably need to merge and try it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blocking change requests are very tiny and additionally a matter of taste. For me the changes are very nice implemented the way they are.
We deceided against your requested changes
We deceided against your requested changes
Description:
We decided to use https://dependabot.com for dependency updates. dependabot is not able to add a new line to changelog.md. Its required to exclude pull requests from dependabot from changelog.md check.
Improvements
Known Issues:
NONE