-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGD links to complexes do not work #1906
Comments
So, the /locus/SGDID only works with locus pages. For a complex, the URL is /complex/SGDID, so yeastgenome.org/complex/S000218003. Can you split the SGDIDs by type? |
@suzialeksander GO policy has been that CURIEs do not contain information that needs to be parsed in the internal ID section. That would be that either SGD supplies a redirect to the right location for the general case or that the ID space is split so that the namespace is used to get things to resolve correctly. There is a similar discussion centered around #659 (comment) ; TAIR and WB have gone through similar questions. |
options:
|
Note that the SGD complexes ID to CPX mappings should also be in the SGD GPI file |
we are requesting please to use the #2 option: have the link go to a https://www.yeastgenome.org/search?q=S000218003&is_quick=true |
@kltm This is still not working as expected - ie the links are not as requested by @srengel https://www.yeastgenome.org/search?q=S000218003&is_quick=true |
Okay, current SGD metadata is: go-site/metadata/db-xrefs.yaml Lines 2372 to 2415 in fe54521
In there, right now, there is a separate SGD_LOCUS namespace, which has the "search" link. The base SGD namespace ("SGD") uses the direct locus link. Is the ask here that the base namespace also uses the search, or that SGD is going to start using more split namespaces. If the former, it would be as simple as adding the search link to that base namespace and doing an update. |
I think these are switched, where logically the base namespace should use the search, the LOCUS namespace should use the direct locus link.
This is what we want. It would fix the complex links correct? |
@suzialeksander Correct. |
Looking to make a better link for #1906 Tagging @suzialeksander
@suzialeksander For example: #2150 |
OK on amigo-staging |
Will close when checked on production AmiGO |
@pgaudet This looks like it's working using the original example. Please close if confirmed. |
SGD annotates complexes with SGD identifiers, for example http://amigo.geneontology.org/amigo/gene_product/SGD:S000218003
However the links we provide from AmiGO are not working
https://www.yeastgenome.org/locus/S000218003
@suzialeksander can you please check why these links are not resolving?
Thanks, Pascale
The text was updated successfully, but these errors were encountered: