Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGD links to complexes do not work #1906

Closed
pgaudet opened this issue Sep 21, 2022 · 13 comments
Closed

SGD links to complexes do not work #1906

pgaudet opened this issue Sep 21, 2022 · 13 comments

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Sep 21, 2022

SGD annotates complexes with SGD identifiers, for example http://amigo.geneontology.org/amigo/gene_product/SGD:S000218003
However the links we provide from AmiGO are not working
https://www.yeastgenome.org/locus/S000218003

@suzialeksander can you please check why these links are not resolving?

Thanks, Pascale

@pgaudet pgaudet changed the title SGD linkt co complexes do not work SGD links to complexes do not work Sep 21, 2022
@suzialeksander
Copy link
Contributor

So, the /locus/SGDID only works with locus pages. For a complex, the URL is /complex/SGDID, so yeastgenome.org/complex/S000218003. Can you split the SGDIDs by type?

@kltm
Copy link
Member

kltm commented Sep 22, 2022

@suzialeksander GO policy has been that CURIEs do not contain information that needs to be parsed in the internal ID section. That would be that either SGD supplies a redirect to the right location for the general case or that the ID space is split so that the namespace is used to get things to resolve correctly. There is a similar discussion centered around #659 (comment) ; TAIR and WB have gone through similar questions.

@cmungall
Copy link
Member

options:

  1. create a SGD.COMPLEX namespace, analogous to what you did for pathways. bioregistry already has both:
  2. have the link go to a https://www.yeastgenome.org/search?q=S000218003&is_quick=true (though the complex doesn't seem to show up in the search?)

@pgaudet
Copy link
Contributor Author

pgaudet commented Dec 14, 2022

Note that the SGD complexes ID to CPX mappings should also be in the SGD GPI file
GOA cannot parse these either.

@srengel
Copy link
Contributor

srengel commented Dec 16, 2022

we are requesting please to use the #2 option:

have the link go to a https://www.yeastgenome.org/search?q=S000218003&is_quick=true

@pgaudet
Copy link
Contributor Author

pgaudet commented Oct 24, 2023

@kltm This is still not working as expected - ie the links are not as requested by @srengel https://www.yeastgenome.org/search?q=S000218003&is_quick=true

@kltm
Copy link
Member

kltm commented Oct 24, 2023

Okay, current SGD metadata is:

go-site/metadata/db-xrefs.yaml

Lines 2372 to 2415 in fe54521

- database: SGD
name: Saccharomyces Genome Database
synonyms:
- SGDID
rdf_uri_prefix: https://identifiers.org/sgd
generic_urls:
- http://www.yeastgenome.org/
entity_types:
- type_name: gene
type_id: SO:0000704
id_syntax: S[0-9]{9}
url_syntax: https://www.yeastgenome.org/locus/[example_id]
example_id: SGD:S000006169
example_url: https://www.yeastgenome.org/locus/S000006169
- database: SGD_LOCUS
name: Saccharomyces Genome Database
generic_urls:
- http://www.yeastgenome.org/
entity_types:
- type_name: entity
type_id: BET:0000000
url_syntax: https://www.yeastgenome.org/search?q=[example_id]&is_quick=true
example_id: SGD_LOCUS:GAL4
example_url: https://www.yeastgenome.org/search?q=S000006169&is_quick=true
- database: SGD_REF
name: Saccharomyces Genome Database
generic_urls:
- http://www.yeastgenome.org/
entity_types:
- type_name: entity
type_id: BET:0000000
url_syntax: http://www.yeastgenome.org/reference/[example_id]/overview
example_id: SGD_REF:S000049602
example_url: http://www.yeastgenome.org/reference/S000049602/overview
- database: SGD_PWY
name: Saccharomyces Genome Database YeastPathways
generic_urls:
- https://pathway.yeastgenome.org/
entity_types:
- type_name: entity
type_id: BET:0000000
url_syntax: https://www.yeastgenome.org/locus/[example_id]
example_id: SGD_PWY:CYSTEINE-SYN2-PWY
example_url: https://pathway.yeastgenome.org/YEAST/NEW-IMAGE?type=NIL&object=SERSYN-PWY

In there, right now, there is a separate SGD_LOCUS namespace, which has the "search" link. The base SGD namespace ("SGD") uses the direct locus link.

Is the ask here that the base namespace also uses the search, or that SGD is going to start using more split namespaces. If the former, it would be as simple as adding the search link to that base namespace and doing an update.

@suzialeksander
Copy link
Contributor

I think these are switched, where logically the base namespace should use the search, the LOCUS namespace should use the direct locus link.

adding the search link to that base namespace and doing an update.

This is what we want. It would fix the complex links correct?

@kltm
Copy link
Member

kltm commented Oct 25, 2023

@suzialeksander Correct.

kltm added a commit that referenced this issue Oct 25, 2023
Looking to make a better link for #1906
Tagging @suzialeksander
@kltm
Copy link
Member

kltm commented Oct 25, 2023

@suzialeksander For example: #2150

@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 17, 2023

OK on amigo-staging

@pgaudet pgaudet closed this as completed Nov 17, 2023
@pgaudet pgaudet moved this from Next release to 2023-11-15 Release candidate in GO releases QC - 2023 Nov 17, 2023
@kltm
Copy link
Member

kltm commented Nov 20, 2023

Will close when checked on production AmiGO

@kltm kltm reopened this Nov 20, 2023
@kltm
Copy link
Member

kltm commented Nov 22, 2023

@pgaudet This looks like it's working using the original example. Please close if confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 2023-11-15 Release candidate
Development

No branches or pull requests

5 participants