Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gorefs.yaml and corresponding JSON Schema validator #1814

Merged
merged 11 commits into from
Nov 1, 2022

Conversation

sujaypatil96
Copy link
Contributor

@sujaypatil96 sujaypatil96 commented Mar 15, 2022

This PR seeks to do the following:

  • Add consolidated gorefs.yaml file created by using the parser written in PR GO_REF yamldown parser #1785
  • Add JSON Schema that can validate the above YAML file
    • Add appropriate descriptions for each of the properties in JSON Schema
    • Validate multiple document structure in YAML file
    • Add further constraints like regex for validation
  • Add LinkML schema
    • Generate Python artifact
    • Generate JSON Schema artifact

CC: @kltm

@sujaypatil96 sujaypatil96 linked an issue Mar 15, 2022 that may be closed by this pull request
8 tasks
@sujaypatil96 sujaypatil96 marked this pull request as ready for review November 1, 2022 23:08
@kltm kltm self-requested a review November 1, 2022 23:16
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sujaypatil96 Looks good! No files changed so same to merge. Adding foundation for future GHAs and deployment. Will also add a README.md later on.

@kltm
Copy link
Member

kltm commented Nov 1, 2022

@sujaypatil96 Feel free to merge once final checks pass.

@sujaypatil96 sujaypatil96 merged commit 0eabf45 into master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new GO_REF metadata and update system
2 participants