Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify protein binding representation #334

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Conversation

cmungall
Copy link
Member

@vanaukenk I can't seem to select you as a reviewer, can you or @monicacecilia take a look at this? @dougli1sqrd is implementing this rule and may have questions.

Note many of these rules were written pre-Noctua. For this one I have added a link to the github ticket geneontology/molecular_function_refactoring#29

@vanaukenk
Copy link
Contributor

Will do, Chris.

@vanaukenk
Copy link
Contributor

Hi @cmungall @dougli1sqrd and @monicacecilia

My understanding of this annotation rule was that it was implemented to make sure there were reciprocal binding annotations for genes/gene products that are annotated to GO:0005515 or one of its children.

To that end, I would explicitly state that in the rule doc; maybe something like this:

+We use the term GO:0005515 and its children to represent instances of protein binding. If a gene G is annotated to this term, its function involves binding another protein. The partner protein is represented in the with/from field of the association, i.e. the 'evidence' is the partner protein. Annotation of gene G to a protein binding term requires that the partner protein also be annotated to a protein binding term, resulting in reciprocal protein binding annotations. Note that the specific protein binding term used for annotation does not have to be the same for each partner.

+Note that this annotation rule predates the existence of annotation extensions (c16 in the GAF). It is more logical to specify the binding partner in c16, this would also allow cleaner separation of evidence from in-vivo activity, but for historic reasons the with/from field continues to be used.

@cmungall
Copy link
Member Author

cmungall commented Mar 9, 2018

ok, made @vanaukenk's changes, I'm going to merge. can do subsequent edits later

@cmungall cmungall merged commit e1fcbdc into master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants