Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize minerva model diff #356

Open
kltm opened this issue Oct 23, 2020 · 5 comments
Open

Optimize minerva model diff #356

kltm opened this issue Oct 23, 2020 · 5 comments

Comments

@kltm
Copy link
Member

kltm commented Oct 23, 2020

To all model responses, add a "diff" of the current (in-memory) state of the model versus the original (on-disk) version.

The purpose is to be able to hint clients on unsaved changes to model.

Details of format TBD.

@goodb
Copy link
Contributor

goodb commented Oct 23, 2020

Same clarification needed as here: #355 (comment)

A quick version of this would be the diff provided by ROBOT which is a list of differing OWL axioms. http://robot.obolibrary.org/diff

@goodb
Copy link
Contributor

goodb commented Oct 29, 2020

@kltm @lpalbou I have the robot diff function embedded in Minerva now for checking the differences between an edited model and the version of the model in the blazegraph store. It is currently set to throw its results (currently available as string, markdown, or html) into a simple string variable in the standard M3BatchResponse. If ROBOT were to add a json format, we could just plug that in here. Ping @jamesaoverton about that possibility. Will commit a change in a sec here..

@jamesaoverton
Copy link

ROBOT relies on https://github.com/balhoff/owl-diff, so it would probably be more effective to ping @balhoff 😄

@lpalbou
Copy link
Contributor

lpalbou commented Oct 29, 2020

I have a meeting today with Tremayne where we will further specify those requirements and see if we need anything else. I will keep you posted later today

@vanaukenk vanaukenk changed the title Add a "diff" to model responses Optimize minerva model diff May 28, 2021
@vanaukenk
Copy link

@tmushayahama - okay to close this one?

@vanaukenk vanaukenk added the ART label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants