Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to add xenbase to jsonld context #125

Merged
merged 1 commit into from
Jul 19, 2017
Merged

attempt to add xenbase to jsonld context #125

merged 1 commit into from
Jul 19, 2017

Conversation

kltm
Copy link
Member

@kltm kltm commented Jul 19, 2017

attempt to feex geneontology/noctua#467

@kltm kltm requested a review from balhoff July 19, 2017 19:53
Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although the IRIs in NEO look like http://purl.obolibrary.org/obo/Xenbase_XB-GENE-1000016. But we have that problem for all the other MODs: geneontology/neo#17

@kltm
Copy link
Member Author

kltm commented Jul 19, 2017

@cmungall Assuming it's already borked everywhere else, I'd just go for it. You?

@kltm kltm merged commit 8d2181b into master Jul 19, 2017
@balhoff balhoff deleted the issue-noctua-467 branch August 1, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants