switched to maven shade plugin #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having problems with unpredictable class loading behavior when building the project using maven command line. Switching from the maven-assembly-plugin to maven-shade-plugin (like in minerva-cli) seems to have resolved the issue.
|
Hang on. reproduced test error. fixing. |
Version 4.5.7 causes MolecularModelManagerTest.testExportImport() to fail in a bizarre and troublesome way. It will hang forever as the MolecularModelManager attempts to save the abox ontology to bytestream (about line 818). I reproduced the problem in separate, simple test file. It only happens if the OntologyManager.applyChange method is called before attempting to write to the stream. e.g. like this: OWLOntologyID ontologyID = new OWLOntologyID(Optional.of(expectedABoxIRI), Optional.of(expectedABoxIRI)); manager.applyChange(new SetOntologyID(aBox, ontologyID)); if that change is not applied it will run just fine. Yay.. So rolling back to working version.
|
This is working now on the dev server. Going forward with merge into dev branch. |
|
As they were the same, will defer switching back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having problems with unpredictable class loading behavior when building the project using maven command line. (There are many different versions of OWL and RDF libraries in the different dependencies.) Switching from the maven-assembly-plugin to smarter maven-shade-plugin (like in minerva-cli) seems to have resolved the issue.